search

flora-pm / flora-server

A package index for the Haskell ecosystem
https://flora.pm/about
Other
124 stars 38 forks source link

[FLORA-198] Fix mismatching OpenSearch names #427

Closed iceCream-Taco closed 11 months ago

iceCream-Taco commented 12 months ago

Proposed changes

Match the "ShortName" field in the OpenSearch XML file with the "title" property in the link to the OpenSearch XML document in the head element. This complies with Mozilla's OpenSearch description format page and results in the "add search engine" button disappearing as it should once Flora has been added.

Also, the OpenSearch description does not make any sense as it now matches the short name, whereas it should describe the search engine (Flora). As it is not relevant I've left it for now, but it should probably be changed to something more appropriate in the future.

Contributor checklist

tchoutri commented 12 months ago

@iceCream-Taco Hi, and thank you for this contribution, it really bugged me. :) From what I understand, both fields should only read "Flora", then?

iceCream-Taco commented 11 months ago

@tchoutri I did consider changing both to Flora, but the search title examples are "Search MDC" and "Yahoo! Search" on the MDN page, and as the title field already read "Search On Flora" I changed the ShortName field to match this instead. Looking around though it does look like most webpages stick with the short name (Wikipedia, Google Cloud, Bing etc.) so I'll change the name/title to "Flora" to match them, as you suggested.

tchoutri commented 11 months ago

Fantastic. Thanks a lot!