florayuan18 / pikachudrinkingwindex

1 stars 1 forks source link

Week 8 Crossover Grading - Kira #57

Closed 4disease closed 2 years ago

4disease commented 2 years ago
FRQ Completed? Deployed? Documentation Input Points
2 Yes Yes Link Yes 1.5
3 Yes Yes Link - 1
4 Yes Yes Link - 1
5 Yes Yes Link - 1
6 Yes Yes Link Yes 1.5
7 Yes Yes Link - 1
8 Yes Yes Link - /1
9 Yes Yes Link - /1
10 Yes Yes Link - /1

Total points: /10

dsblack0 commented 2 years ago

Comments per FRQ

FRQ Completed? Deployed? Documentation Input? FRQ Comments Points
2 Yes Yes Complete and thorough Yes I think it would have been helpful if explained what was being outputted when you asked for "Sq root first/second numbers" Also, the square root part of this frq doesn't seem to be working as intended since it keeps truncating the decimal values to an integer. Make sure that you cast the values to decimals so that you are given the full proper output. 1.25/1.5
3 Yes Yes Complete and thorough No It is a little confusing to understand what is happening when I just run this frq because none of the default input values are listed. Listing the default values on the runtime would help give context to the frq. Something you could try if you were to include an input for this frq is to have the user input two different options and then compare both of those to see if they are the same 0.75/1
4 Yes Yes Complete and thorough Yes It would still be a little more helpful if you included something that allowed someone else to understand what was happening when they simply ran the frq but this one worked very well with giving the input and additional information on the longest streak. 1/1
5 Yes Yes Complete and thorough Yes for the first question The invitation frq worked very well with the inputs, being able to change the address, and giving the final invite sentence for the output. For the password section of the frq, it was hard to follow what was happening on the runtime since you didn't include what the default values you used were 1.5/1.5
6 Yes Yes Complete and thorough No The frq worked well and gave all of the desired outputs and it was much easier to follow as you gave the default values for the list of items sold as well. It would also have been helpful if you gave the default list of words for the first word select question as well 1/1
7 Yes Yes Complete and thorough No This frq worked well with the default values being clear and it was also easier to understand what was happening in the frq from your descriptions 1/1
8 Yes Yes Complete and thorough No This frq worked well but it was hard to follow without referencing back with the code because I wasn't able to see what the default data for the farm plots was. 1/1
9 Yes Yes Complete and thorough No This frq worked well and all of the outputs were clear to understand 1/1
10 Yes Yes You could have been more specific with this reflection by referring to more specifically what java concepts you used within your code, like while loops. Also since the focus of Unit 10 is on recursion, it might be helpful to try implementing the same code using recursions instead of while loops too. No The frq is running properly, but similar to some of your other frqs, it was pretty hard to follow what exactly the code was doing with knowing what the default inputs were. You could also add to the frq a little by also listing the GCF of the numerator and denominator when you reduce the fractios. 0.75/1

Overall Comments

Overall Grading

4disease commented 2 years ago

Reflection