florayuan18 / pikachudrinkingwindex

1 stars 1 forks source link

Week 11 Crossover Grading - Maggie #73

Open meghanakillada opened 2 years ago

meghanakillada commented 2 years ago

Link to Wiki

dsblack0 commented 2 years ago

Team Grading

PBL Github Pages, Jekyll, WIKI

Criteria\Feature Comments Score
PBL theme consistent through project and described in Github Pages Your theme and key ideas are all described in Github Pages and you have a good consistent theme throughout the project 0.5/0.5
Sassy / Bootstrap illustration in GitHub pages You have sassy implemented on your site and it is working properly with the dark more 0.5/0.5
Database - CRUD operations on project centered database tables and describe in GitHub Pages It seems like your started on the login database but the code doesn't look complete with CRUD implemented. I can only see the controller for the login and the rest of the files seem to be empty. The database for the reviews is looks complete but I am not able to access it on the deployed site 0.4/0.5
Deployed Project 24/7 - Deployment Overview and Policies described in GitHub Pages All policies are described in Github Pages but the project isn't fully deployed as there are multiple pages that are giving errors. I believe this is because of an extra "/" in the return statement of the controller 0.2/0.5
Async Operation (ie JavaScript fetch) described in GitHub pages JavaScript fetch was used along with the search and api feature on the "Search" Page 0.5/0.5

Review Video

Criteria\Feature Comments Score
Highlight of best features Best features of the search and recommendations are shown and working properly 0.5/0.5
Scrum Board - overview of completed tasks and GitHub tangibles The scrumboard has a lot of work that is in progress so does this mean that parts of your project aren't completed yet? Also it was very hard for me to find a lot of the code and elements of your project because none of the tangibles were linked on the review tickets. 0.1/0.5
MVC Package - a code overview showing a complete MVC package I can see the full MVC package with the search API 0.5/0.5
Search on project database tables, easy to identify from UI Search through database is shown on the "Search" page that goes through the database of different games 0.5/0.5
Google Search or Google translate implemented A Google Search is present and working 0.5/0.5

Team Score: 4.2/5

Individual Grading

Criteria\Feature Comments Score
One PBL MVC feature (per indi/pair) I can see how you used an API and then connected that data to the frontend where you implemented the search feature but I don't see a very clear Model in your work. It seems like most of the code is just your Controller and View. 0.7/1
Individual commits showing algorithms written in JS and/or Java Individual commits where made pretty consistently and I can see the work that you contributed with the Java code and Javascript that you used. 1/1
Wiki with design ideas and usage Wiki details the design and technical ideas that you were planning on and did implement on your site. 1/1
Final program code (created independently or pair) I believe that the cause of the 500 error on your deployed site may be that in this line , you included a / that shouldn't be there
1 Minute Video Your video shows your running page and it looks like it works well and is very organized. To make the page even more user-friendly, you could also have made all the games be sorted in the order of their rating so that users can see which games are the more recommended first. 0.8/1

Individual Score: 4.5/5

Total Score: 8.7/10

Graded by Sam Duggirala