search

florentbr / OWON-VDS1022

Unofficial release for the OWON VDS1022/I Oscilloscope
259 stars 45 forks source link

installer script fails with CP error #4

Closed sonic84 closed 4 years ago

sonic84 commented 4 years ago

macOS cp does not like --no-preserve

error: 

===========================================================
 Install application 'owon-vds-tiny'
===========================================================

Locate Java Runtime ...

JAVA_HOME :
  /Library/Java/JavaVirtualMachines/jdk1.8.0_241.jdk/Contents/Home

Install application ...
cp: illegal option -- -
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file ... target_directory

workaround:

remove --no-preserve=mode,ownership from cpdir and cpfile functions. 

cpdir () {
    mkdir -p "$1"
    cp -r "${@:2}" "$1"
}

cpfile () {
    mkdir -p "$(dirname "$1")"
    cp  "$2" "$1"
}
===========================================================
 Install application 'owon-vds-tiny'
===========================================================

Locate Java Runtime ...

JAVA_HOME :
  /Library/Java/JavaVirtualMachines/jdk1.8.0_241.jdk/Contents/Home

Install application ...

BINARY:
  /Applications/OWON VDS1022 Oscilloscope.app/Contents/MacOS/owon-vds-tiny

Done!
florentbr commented 4 years ago

fixed in release 1.0.30-cf10