search

florentbr / OWON-VDS1022

Unofficial release for the OWON VDS1022/I Oscilloscope
259 stars 45 forks source link

Windows version does not work with version greater than OpenJDK 8 (LTS) #7

Closed csdpm closed 4 years ago

csdpm commented 4 years ago

Firstly, thanks for a great quality enhancement of the VDS1022 software!

There seems to be a compatibility issue with the OpenJDK version...

In the Dependencies section of your README.md it states: "This software requires Java Runtime Environment 8 or superior". The https://adoptopenjdk.net page currently defaults to OpenJDK 11 (LTS). I have found that with this version, your software (although it installs completely) fails to recognise the VDS1022 Hardware, even though it appears correctly in the Device manager.

Uninstalling OpenJDK 11 (LTS) and manually selecting and installing OpenJDK 8 (LTS) resolves the problem.

Tested in Win 10 environment only.

florentbr commented 4 years ago

Looks like the flag java -d64 is no longer present with JAVA OpenJDK 11 on Windows. It is used by the installer to determine the bitness of Java. Without this flag, the script installs the 32bit libraries which can't be used by Java 64bit.

To overcome this issue, just comment the code from line 44 to 48.

csdpm commented 4 years ago

Many thanks for the very fast explanation and resolution Florent. :)

florentbr commented 4 years ago

fixed in release 1.0.30-cf10