fluree / db

Fluree database library
https://fluree.github.io/db/
Other
334 stars 21 forks source link

Fix list retraction #824

Closed cap10morgan closed 1 month ago

cap10morgan commented 1 month ago

The retraction code was conceptually duplicated from the assertion code, but implemented pretty differently (when 99% of the time the only necessary difference was the false arg to flake/create). This was causing list retractions to fail b/c lists weren't handled in the retraction code.

This DRY's up the assert/retract code and fixes the list retraction issue. Ideally I would add a test in here for the list retraction issue, and I will attempt to do that. But I don't want to spend too much time on it. I do have an integration test in another project that went from failing to passing with these changes.

cap10morgan commented 1 month ago

I added a test