flxzt / rnote

Sketch and take handwritten notes.
https://rnote.flxzt.net
GNU General Public License v3.0
8k stars 274 forks source link

put selection handle outside selection #1050

Closed Doublonmousse closed 6 months ago

Doublonmousse commented 6 months ago

image

flxzt commented 6 months ago

Thanks, that looks pretty straight forward. I know you didn't adjust the selection minimum size intentionally, but value [2., 2.] should be pretty safe wrt to numerical stability when resizing. I think we can do that without any issues

Doublonmousse commented 6 months ago

I've updated the minimum size (for now it's set at 2.0 / zoom_level). I don't see any of the issues I had with me setting it to 0.01 so that's good.

Having smaller minimum selection size does make #1017 more prominent though. I feel like changing the stroke width calculation so that the following are true could help a little though (maybe a pattern matching could suffice)

At least it would remove the issue for resize that are done on a single direction, leaving only the case of a series of resizes that are neither uniform nor done in a single direction without having to calculate the stroke width with respect to the initial size of the selection

flxzt commented 6 months ago

That's a very interesting idea, let's discuss it further in #1017

flxzt commented 6 months ago

Thank you! :)