Closed flxzt closed 2 months ago
@Doublonmousse if you want/have enough time, please review!
Good points, thanks.
I think I misunderstood the value
field in the hsv colorspace while implementing this. I now fixed and improved the logic by:
approx::rel_eq
with f32's epsilon for min/max values. It's relevant because the picked colors come from gdk, which only has f32 precision.transparent
, translucent
, slightly-translucent
and `` (empty string == opaque)
This adds the following:
Still a draft, because rnote-compose now needs to be translated with gettext as well. I'll see how to best integrate or refactor it
addresses #658