flxzt / rnote

Sketch and take handwritten notes.
https://rnote.flxzt.net
GNU General Public License v3.0
6.42k stars 214 forks source link

Modified file on disk popup appears under bottom toolbar #1087

Closed parmjotsinghrobot closed 1 month ago

parmjotsinghrobot commented 1 month ago

Describe the bug
The popup showing that "opened file was modified on disk" appears under the bottom toolbar

To Reproduce

  1. Open rnote, then open a document.
  2. Modify it in some way outside of rnote (like opening it in two instances so that autosave does it for you)
  3. See it pop up below the bar.

Expected behavior
It to appear above the bar.

Console Output
Layering issue so why?

Screenshots
Pretty tough to get a good issue so please make do with what I have. (its the notch on the bar if you must) 20240501-18_17_20_grim

Desktop (please complete the following information):

flxzt commented 1 month ago

It looks like you are using a custom theme. The margin of the toasts (the notifications) is set by css, your theme likely breaks it. I recommend not applying the theme for Rnote.

parmjotsinghrobot commented 1 month ago

It looks like you are using a custom theme. The margin of the toasts (the notifications) is set by css, your theme likely breaks it. I recommend not applying the theme for Rnote.

Is it not possible to layer the toast above the toolbar? Since this isn't the most ideal way to use the app. (Yes, it works with no theme set)

flxzt commented 1 month ago

It might be possible, but this is likely not the only place where your theme breaks the styling of the app and it's not possible to anticipate the changes any theme would make. You should either try to fix this in your theme just disable it because it's not supported.