flxzt / rnote

Sketch and take handwritten notes.
https://rnote.flxzt.net
GNU General Public License v3.0
6.42k stars 215 forks source link

Page layout doesnt get fully persisted #1092

Open MariusAlbrecht opened 1 month ago

MariusAlbrecht commented 1 month ago

Describe the bug
Both the format setting (e.g. A5) and the units (px, mm, cm) sometimes get lost. I observe two scenarios two scenarios:

To Reproduce
Steps to reproduce the behavior:

  1. Create document and assign it a Wayland (e.g. A5)
  2. Save
  3. Close (the document or the app)
  4. Open (the app and then) the document again
  5. Go to settings and see error(s)

Expected behavior
persist and restore all info. In particular, restore the predefined page layout choice

Console Output
n/a

Desktop (please complete the following information):

flxzt commented 1 month ago

The dimensions themselves are persistet, the A4/A5/.. choices are not included in the format. Because the underlying combination of DPI and lengths can be unlimited for all formats, for example A4 at a lower DPI can be the same as A5 with higher DPI, it's difficult to restore them unambigiously.

But we could add storing the choice in the file format/user settings because I can see how it would be less confusing for users.