search

flxzt / rnote

Sketch and take handwritten notes.
https://rnote.flxzt.net
GNU General Public License v3.0
6.42k stars 215 forks source link

ui: migrate to libadwaita-1.5 and its adaptive dialogs #1110

Closed zefr0x closed 2 weeks ago

zefr0x commented 3 weeks ago

I've used AdwAboutDialog and AdwAlertDialog in place of AdwAboutWindow and AdwMessageDialog respectively.

Old dialogs using GtkDialog are still displayed in separate windows. We might look at the possibility of using AdwDialog as an alternative.

flxzt commented 2 weeks ago

Looks good and straight forward, is the reason that this is a draft because you want to look into using AdwDialog instead of GtkDialog or will this be a possible follow-up?

zefr0x commented 2 weeks ago

is the reason that this is a draft because you want to look into using AdwDialog instead of GtkDialog or will this be a possible follow-up?

Yes, if you want, you can merge these changes now, but it may be a good idea to merge them all at once.

I didn't find time to look into AdwDialog, but from a fast reading, I can say that actions related functionalities present in GtkDialog are not present in AdwDialog, so they may have to be implemented manually.

flxzt commented 2 weeks ago

Hm, not yet sure why the CI fails. The used Fedora container should have libadwaita v1.5 available..

flxzt commented 2 weeks ago

oh, of course we need to use fedora 40

flxzt commented 2 weeks ago

I didn't find time to look into AdwDialog, but from a fast reading, I can say that actions related functionalities present in GtkDialog are not present in AdwDialog, so they may have to be implemented manually.

This is why I think it can be a follow up since it requires more refactoring than the other replacements.

I'll merge this now, and open an issue for tracking GtkDialog -> AdwDialog porting

flxzt commented 2 weeks ago

Thanks for this contribution!