feat: Lock tool style - Githubissues

flxzt / rnote

Sketch and take handwritten notes.

https://rnote.flxzt.net

GNU General Public License v3.0

6.42k stars 215 forks source link

feat: Lock tool style #1119

Open Doublonmousse opened 2 weeks ago

Doublonmousse commented 2 weeks ago

Fixes #1104

As of now the lock option is added with a overlay popup that allows unlocking the current pen tool (pen or eraser). What's left to do is

[x] expose the option to lock/unlock tools somewhere in the UI.

I think it makes sense to add this in the Button Shortcuts portion of the settings with the added benefit of being able to change tools for pen/eraser there, and the dropdown (temporary/ ...) changed to a locked padlock/unlocked padlock toggle button

Doublonmousse commented 1 week ago

Well, I'm kinda stuck with a BorrowMut error for the (hopefully) very least part of code needed to have a functioning first prototype (with potentially some more bugs/cleanup to do, one of which is getting new icons).

Doublonmousse commented 6 days ago

This finally works. Probably nitpicks to be fixed

change_pen_eraser_style to be merged into an existing function using an optional argument
change_style_single_mode : same thing
change_style_pen_eraser_int : same thing
set_style_single_mode : same thing

Edit : done