flxzt / rnote

Sketch and take handwritten notes.
https://rnote.flxzt.net
GNU General Public License v3.0
7.87k stars 267 forks source link

Erratic scrolling behaviour when pinch to zooming on trackpad. #885

Open RayJW opened 10 months ago

RayJW commented 10 months ago

Describe the bug
Sometimes when using the pinch to zoom action on the trackpad, Rnote can scroll very fast, unwontedly across the document.

To Reproduce
Steps to reproduce the behavior:

  1. Open any note.
  2. Use the pinch to zoom gesture a few times.
  3. If it doesn't happen, make sure to lift your fingers and 'restart the gesture'.
  4. Around one out of ten times, the note will just scroll unexpectedly.

Expected behavior
Pinch to zooming should just adjust the zoom and not the location on the note.

Console Output

2023-11-16T09:58:52.828Z DEBUG rnote > ... env_logger initialized

(rnote:2): Gtk-CRITICAL **: 10:58:53.120: gtk_widget_class_set_accessible_role: assertion '!gtk_accessible_role_is_abstract (accessible_role)' failed

Desktop (please complete the following information):

Additional context
I think it's a Rnote gesture issue because it doesn't happen with any application so far, GTK or not. It feels like the location sometimes doesn't get locked, thus you "zoom" to the location of the whole note of where your cursor is instead of from what's visible on the screen at the moment. It never happens when pinch to zooming on the touchscreen, specifically only with the trackpad.

felipe-juan commented 9 months ago

I have the same issue and I would almost start a new thread just to say this lol

Anyway, I recorded the following videos comparing it to Drawboard, which is how it should behave instead:

Two-Finger Scrolling: https://github.com/flxzt/rnote/assets/85803620/002ee1c7-7fa1-492e-a8bd-6b3cb7f2d96b

Pinch to Zoom: https://github.com/flxzt/rnote/assets/85803620/b7e5f8a3-3a1e-4d07-8202-67e0fbf6cd30

Extra Information:

arturopitu commented 8 months ago

I believe it's a GTK bug since Evince shows the same bug, at least in my experience. (Debian 12, gnome 42, 0.9.4)

RayJW commented 2 months ago

Since there hasn't been any activity on the side of GTK in the last three+ years, it might be worth just not using their implementation. This seems to be the route Xournal++ chose as well. Since, I think personally, this bug is incredibly infuriating and makes it very frustrating working with longer documents in Rnote.