search

fly-apps / laravel-docker

Base Docker images for use with Laravel on Fly.io
38 stars 8 forks source link

Add support for PHP 8.3 #7

Closed jonathan-lewerissa closed 8 months ago

jonathan-lewerissa commented 8 months ago

Added support for PHP8.3

Do I need to update the Dockerfile and Dockerfile-unit default args as well?

fideloper commented 8 months ago

Hi! I think we can leave those at 8.2 for now.

Note that this script needs updating as well (may as well do it in the PR!) https://github.com/fly-apps/laravel-docker/blob/main/build.sh#L12

Did you get a chance to test that out? Some packages are not yet ready for php 8.3 (most notably php8.3-redis). We COULD get php 8.3 built ahead of those, I was hoping they'd come out soon.

jonathan-lewerissa commented 8 months ago

I've updated the build script as well. https://github.com/fly-apps/laravel-docker/pull/7/files#diff-4d2a8eefdf2a9783512a35da4dc7676a66404b6f3826a8af9aad038722da6823L12-R13

I've only tested the update locally, but can probably make an updated deployment (will send the link).

Also for the packages php-redis, php-swoole, it should be available now https://github.com/oerdnj/deb.sury.org/issues/2034

jonathan-lewerissa commented 8 months ago

Tested the image here: https://834a6ff9-ea77-4f95-82a7-ced4437a86b4.fly.dev/

fideloper commented 8 months ago

Thank you! I appreciate you taking the time on this!