fnf-org / TicketBooth

Rails 7.1 app for creating closed community events, distributing the ticket request URL, approving and selling tickets via Stripe Integration.
https://fnf.org
Other
9 stars 3 forks source link

Ticket requests goes in bad state after adjusting price to $0 after approval (Inconsistent) #162

Closed yarunluon closed 5 months ago

yarunluon commented 5 months ago

Describe the bug
[Inconsistent] If an Admin adjusts the ticket price to $0 after approving the Ticket Request, the system still expects the requester to go into the Payment flow rather than setting the ticket status to Completed.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new account
  2. Create a new ticket request: https://tickets.fnf.events/events/14-fnf-2024-summer-campout/ticket_requests/new
  3. Copy the Ticket Request url
  4. Log into the Admin account and go to the Ticket Request url
    1. user: tickets+approved01@fnf.org
    2. pass: yukon-MELODIC-lamprey
  5. Approve the ticket
  6. Set the ticket price to $0
  7. [Sometimes happens] The system still wants the user to go into the payment flow. Ideally the system will mark the status as "Completed" and there is no need to go into the Ticket Request flow.

Expected behavior
If the Admin sets the price as $0, the system will mark the transaction as completed. If the Admin goes back and changes the ticket price to something greater than $0 then the requester will need to go into the Ticket Request flow.

Screenshots
modify-special-pricing-after-approval

Logs
No New Relic log found

Additional context
This is inconsistent behavior. Sometimes the system correctly identifies the $0 price and sets the ticket request status to Completed.

Version info
App Version: 1.0.1
Rails: 7.1.3.2
Ruby: 3.2.3
Mode: production

yarunluon commented 5 months ago

Closing the ticket to be tracked later.

yarunluon commented 5 months ago

Another example of an inconsistent state image