search

fogleman / Minecraft

Simple Minecraft-inspired program using Python and Pyglet
MIT License
5.25k stars 1.24k forks source link

Fixed ctypes error and load directly from PNG #3

Closed BlainMaguire closed 11 years ago

BlainMaguire commented 11 years ago

Added ctypes import to fix an error on my machine.

Texture is now imported directly from PNG (removed base64 string code, including encode.py as it is no longer needed).

jminardi commented 11 years ago

:+1:

ubershmekel commented 11 years ago

These should be 2 separate pull requests.

The ctypes import issue was just a bug which should be fixed and merged.

The png thing - I'd guess the author wanted to distribute this thing as one python file that does minecraft, and wouldn't want to merge that change at all. Though I am of the opinion that it'd be neater with a direct png access so young users can edit the texture easily with a paint program.

jcla1 commented 11 years ago

:+1: Makes the code a lot shorter!

ubershmekel commented 11 years ago

We aren't golfing. And the texture string really isn't "code". On Mar 29, 2013 12:51 PM, "Joseph Adams" notifications@github.com wrote:

[image: :+1:] Makes the code a lot shorter!

— Reply to this email directly or view it on GitHubhttps://github.com/fogleman/Minecraft/pull/3#issuecomment-15634475 .