Update font name; Add PAT token as authentication.

fork-my-spoons / jira-issues.spoon

Jira issues in your menubar

MIT License

18 stars 2 forks source link

Update font name; Add PAT token as authentication. #3

Open poliveira-fuze opened 6 months ago

poliveira-fuze commented 6 months ago

This pull request includes changes to the init.lua file, primarily focusing on the modification of icon fonts and the addition of a new authentication method. The most significant changes are:

Icon Font Modification:

init.lua: The show_warning(status, body) function has been updated to use the 'icomoon' font instead of the 'feather' font for both user_icon and ticket_icon.

Authentication Method Addition:

init.lua: In the setup(args) function, a new authentication method has been added. If an API token is provided, it will be used for authentication. Otherwise, a PAT token will be used.

poliveira-fuze commented 6 months ago

Hello @streetturtle, apologies for the tag, I wanted to do it by adding as reviewer. But it seems I can't do it.

streetturtle commented 6 months ago

Hey-hey! Thank you for this PR! Could you please add to the readme how to install icomoon font please.

streetturtle commented 6 months ago

Could you please also bump the version to 1.3.

jagibson commented 1 month ago

@streetturtle regarding the icomoon font - When I click on the link for 'feather.ttf' from your readme and attempt to install it, it says the name is 'icomoon' and not 'feather'.

streetturtle commented 1 month ago

It looks like icomoon is a software to create fonts. Maybe it was used to generate the font, and it automatically overrode the original font name. I'll do few tests and will post here.

jagibson commented 1 month ago

Yeah, when I download version c51fe7c from https://github.com/AT-UI/feather-font it goes back to the name "feather".