A fresh theme

[namangoel1]

Completely updated the site, creating a new design from scratched. Added images of mentors and students, with two placeholder slots for those who wish to complete the other tasks.

[namangoel1]

Preview here: http://codein.namanyayg.com/fossasia/site/

[kokoye2007]

gr8! job.

cool and clean

On Fri, Dec 5, 2014 at 2:33 PM, namangoel1 notifications@github.com wrote:

Preview here: http://codein.namanyayg.com/fossasia/site/

— Reply to this email directly or view it on GitHub https://github.com/fossasia/fossasia.github.io/pull/1#issuecomment-65758364 .

Ko Ko Ye`

+95 973147907 +95 94500 22022

kokoye2007@gmail.com kokoye2007@ubuntu.com

skype: kokoye2007 jit.si: kokoye2007

http://ubuntu-mm.net http://wiki.ubuntu.com/kokoye2007 http://wiki.ubuntu.com/MyanmarTeam http://loco.ubuntu.com/teams/ubuntu-mm

[namangoel1]

@kokoye2007 Thanks! Any changes you'd like to see?

[roonyh]

@namangoel1 Overall work is really good. However your work on git could have been better. For example commit messages should be more descriptive of the work they contain. Just two words as a commit message is really very less useful. When working on a collaborative project you must make sure that your work can be worked on later by other people. A good commit message helps others a lot to understand what happens inside the commit. Just google "What is a good commit message". You don't have to follow every instruction that would come up from this search. But try to write useful commit messages.

Another less important advice might be to have cleaner commits. For example README.md file is changed by you across 3 commits where it really logically could have been done in one commit itself. It really takes time to practice this so don't worry about it. But have a look at git reset and git interactive rebase if you have time which can help you to achieve this.

[namangoel1]

@RoonyH I understand and will keep this in mind for the future commits. Getting this set-up was a bit hacky I agree, I ported compiled files from Gulp into the repo and thus have messy commits.

[roonyh]

@namangoel1 I think you should still give those commits better commit messages. And get rid of the third commit and squash it into the second. Use git interactive rebase. Its a nice tool to know about. You can always clone again from here if you mess up :) give it a try!

[namangoel1]

@RoonyH Can't seem to figure out how to use git interactive rebase.

If I do: git rebase -i origin/master simply shows noop in the vim shell. Not sure what I'm doing wrong. Could you help out through IRC or something if it is okay?

[roonyh]

@namanyay1 I am travelling right now, so wouldnt be able to join IRC. Try git rebase -i. Try to search about it.

[namangoel1]

Thanks for merging. I tried git rebase -i and it always shows me 'noop'. Tried it on the origin (which failed), origin/master (noop) and master (noop) branches. I am not sure why. Shall I create another pull request for demonstration?

[roonyh]

@namanyay1 thanks much! Learn about git rebasing when you have time. Lets get this nice work of yours in for now. Thanks again!

[namangoel1]

@RoonyH Great, thank you! Will do.