fossasia / gci14.fossasia.org

FOSSASIA Google Code-In Website 2014/15 http://gci14.fossasia.org
1.57k stars 109 forks source link

Made Changes Asked By GCI Task #110

Closed Ludwant closed 9 years ago

Ludwant commented 9 years ago

I added myself, according to the Google Code-in Task.

roonyh commented 9 years ago

Hi thanks and welcome! There some unnecessary files named ".DS_Store" in the commit. Please remove those.

Ludwant commented 9 years ago

Hi, sorry for the .DS_STORE files. When I added my picture and edited index.html I used "git add -a" which included those files. I fixed it now, hope everything else is fine. Thank you!

roonyh commented 9 years ago

Great! Thanks! Now can you please rebase your work on the updated master branch? The code in our repo has changed since you made the pull request. This makes it harder to merge. Reading this should help: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

Ludwant commented 9 years ago

Alright, I rebased it. It should be good. Thanks again.

roonyh commented 9 years ago

Thanks! great job! just remove those unnecessary lines like "<<<<<<< HEAD" and "=======" You have done rebasing correctly except those lines are not needed and should be deleted.

And you can add a nice animation to your image with <div class="box-team wow bounceInDown" data-wow-delay="0.3s"> Checkout other images.

Ludwant commented 9 years ago

I added the delay and took out the unnecessary lines. Let me know if there is something else I need to do. Thank you for your help.

roonyh commented 9 years ago

Thanks :+1: ! you can check https://github.com/fossasia/fossasia.github.io/pull/110/files for changes you made. Can you please remove those unnecessary lines? and fix indentation where wrong. Thanks for your work and sorry for nit picking :smile:

Ludwant commented 9 years ago

Thats fine! Took out the /divs, and fixed some indentation. Sorry for those little errors. I'm guessing that with a community project, the code needs to be kept neat! Thanks again, hope everything else if okay.

Ludwant commented 9 years ago

Hello?

namangoel1 commented 9 years ago

@Ludwant Merged, sorry for the delay!

Ludwant commented 9 years ago

Thank you so much!

roonyh commented 9 years ago

I am terribly sorry for not responding. I was offline for the last few days. Thanks @namangoel1 for attending to this :+1: @Ludwant I hope the task associated is closed?

Ludwant commented 9 years ago

That's fine! I ran out of time on the task, so I reclaimed it, but it is not closed on the GCI website.

roonyh commented 9 years ago

Will close it if you could give me a link.

Ludwant commented 9 years ago

The link to the task is this: http://www.google-melange.com/gci/task/view/google/gci2014/5803979057397760 Thanks for all your help!

roonyh commented 9 years ago

Please submit a link to this pull request as the work and mark the the task as complete.

Ludwant commented 9 years ago

I put the link up and marked it as complete.

Ludwant commented 9 years ago

Thank you!

roonyh commented 9 years ago

You are welcome!