search

fossasia / gci14.fossasia.org

FOSSASIA Google Code-In Website 2014/15 http://gci14.fossasia.org
1.57k stars 109 forks source link

Change number of columns to five in contributors section #132

Closed meghprkh closed 9 years ago

meghprkh commented 9 years ago

Part of task : http://www.google-melange.com/gci/task/view/google/gci2014/5792122582073344

I think that it works perfectly. Test it @ http://meghprkh.github.io/fossasia.github.io/#contributors

meghprkh commented 9 years ago

The first commit just updated my repo

roonyh commented 9 years ago

Contributor images look really bad on mobile devices. See attached. Can you please fix this. You'll increase the minimum width of contributor images for this. Thanks! fossasia google code in 2014 15

meghprkh commented 9 years ago

What is your pixel resolution?

It works nicely in FF's responsive tool.

But does the menu work at all for it does not work in FF?

screenshot from 2014-12-24 10 24 29

roonyh commented 9 years ago

Try on a tablet size. eg: nexus 7. (600x960)

Btw your work so far is really good. We just need this small fix and it can go in! This should not be a hard fix. Try to add a css class for contributor images and set min width to something smaller than the current one.

meghprkh commented 9 years ago

What about having 3 instead of 5 colums in contributor section on medium screen devices?

This looks clean.

See http://meghprkh.github.io/fossasia.github.io/ in FF responsive mode or on your tab.