fossasia / gci14.fossasia.org

FOSSASIA Google Code-In Website 2014/15 http://gci14.fossasia.org
1.57k stars 109 forks source link

Revert "Another commit with many small fixes [Urgent]" #150

Closed mariobehling closed 9 years ago

mariobehling commented 9 years ago

Reverts fossasia/fossasia.github.io#140

There are too many small changes. I find it difficult to preview everything. Maybe you could set up a test website on github for so many changes. I understand that there are different views on design, but we also need to take care that different students are contributing. I see three issues here:

namangoel1 commented 9 years ago

@mariobehling I've added background colors to the mentor and student sections. What do you mean by the 'background color of bottom section', though? I'm going to fix Twitter now on #154 Thank you!

My changes primarily related to code cleanliness, removing redundancy (jQuery ~1.1 was called twice in index.html, replaced with 2.1 for example) and making it more semantic (removing the multiple IDs for slides, and removing the redundant div. Less repetition of code in the stylesheet, too).

namangoel1 commented 9 years ago

I've fixed the three things in #154 . Please let me know if there's anything else.