search

fossasia / gci14.fossasia.org

FOSSASIA Google Code-In Website 2014/15 http://gci14.fossasia.org
1.57k stars 109 forks source link

Integrating scss-lint through Gulp with Travis CI #198

Closed namangoel1 closed 9 years ago

namangoel1 commented 9 years ago

Once I'd done the integration, had to fix many, many errors across various files. Hence 11 files changed.

roonyh commented 9 years ago

Excellent! But are you changing libraries from other parties? https://github.com/namangoel1/fossasia.github.io/blob/gh-pages/stylesheets/partials/_animate.scss

namangoel1 commented 9 years ago

@RoonyH yes, but that's only to change the indentation and change 0 to simply be 0. scss-lint was giving warnings. It doesn't matter in validation or execution, though.

roonyh commented 9 years ago

Is there a way to exclude external code from linting? and maybe have them in a separate directory too.

namangoel1 commented 9 years ago

Sure @RoonyH, can be done. I don't see why, though - I have fixed all errors in this commit, most were related to indenting anyway. If you see Travis' output, you'll find that there are no errors or warning for any of the included files.

I have excluded _animate.scss because there still were some warnings there (SCSS lint does not like names in camelcase and forces dash-separation instead).

You on IRC right now?

roonyh commented 9 years ago

I see the travis build and know that there are no problems :) But I don't like messing with external code. say there is a new update to this file. and we want to get it. There will be merge conflicts. External code is external code :) From experience I know that they are best kept that way. I am on IRC.