search

fossasia / gci14.fossasia.org

FOSSASIA Google Code-In Website 2014/15 http://gci14.fossasia.org
1.57k stars 109 forks source link

Finished task - http://www.google-melange.com/gci/task/view/google/gci2014/5617184554352640 #21

Closed tradzik closed 9 years ago

tradzik commented 9 years ago

I have finished this task for Google Code-In : http://www.google-melange.com/gci/task/view/google/gci2014/5617184554352640

Unfortunately, I can't claim it, because my "current" task is still pending review -.- Please do not assign it to anybody other than me - this task is finished.

roonyh commented 9 years ago

Good job. Thank you! Can you be a little more helpful for the new students by adding more instructions on how to add their pictures and links? You can specify git commands, where they should copy there pictures and specific html tags they should put into the index.html file.

tradzik commented 9 years ago

Sure, I can and I will do that in the second (or tomorrow - it is midnight in my timezone). Can please review my task?

Sun Dec 07 2014 at 23:23:14 użytkownik Aruna Herath < notifications@github.com> napisał:

Good job. Thank you! Can you be a little more helpful for the new students by adding more instructions on how to add their pictures and links? You can specify git commands, where they should copy there pictures and specific html tags they should put into the index.html file.

— Reply to this email directly or view it on GitHub https://github.com/fossasia/fossasia.github.io/pull/21#issuecomment-65958404 .

roonyh commented 9 years ago

Great! I am sorry but I don't know much about Raspberry Pi. I'll ping the mentors about it.

tradzik commented 9 years ago

Thank you. I hope my task'll be reviewed quickly, because I want to finish much more :-)

Sun Dec 07 2014 at 23:42:36 użytkownik Aruna Herath < notifications@github.com> napisał:

Great! I am sorry but I don't know much about Raspberry Pi. I'll ping the mentors about it.

— Reply to this email directly or view it on GitHub https://github.com/fossasia/fossasia.github.io/pull/21#issuecomment-65959217 .

tradzik commented 9 years ago

I have already did that what you asked for.

roonyh commented 9 years ago

Nice!! Please use inline html to add specific html changes that the students should make to add there picture to the site.

roonyh commented 9 years ago

And please submit a link to this pull request as work on your task.

roonyh commented 9 years ago

This is a great opportunity for you to learn about git squashing. It will be a nice challenge and would come handy for you in future. Its fine if you are busy with a task and not want to get into this right now. But want to give it a try and squash last 6 commits into one?

tradzik commented 9 years ago

Ok, I'll read about that. Currently I am working on task (you're mentoring :-) ) and will take care of that later

On 06:14, Wed, Dec 10, 2014 Aruna Herath notifications@github.com wrote:

This is a great opportunity for you to learn about git squashing http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html. It will be a nice challenge and would come handy for you in future. Its fine if you are busy with a task and not want to get into this right now. But want to give it a try and squash last 6 commits into one?

— Reply to this email directly or view it on GitHub https://github.com/fossasia/fossasia.github.io/pull/21#issuecomment-66405732 .