search

fossasia / gci14.fossasia.org

FOSSASIA Google Code-In Website 2014/15 http://gci14.fossasia.org
1.57k stars 109 forks source link

JSCS validateIndentation #219

Closed samarsault closed 9 years ago

samarsault commented 9 years ago

Enforce validateIndentation to accept only 2 spaces for indentation and lint main.js according to that

namangoel1 commented 9 years ago

Can you link your task please?

samarsault commented 9 years ago

https://www.google-melange.com/gci/task/view/google/gci2014/5257295269199872 Here you go

samarsault commented 9 years ago

btw why's the build's failing ??

namangoel1 commented 9 years ago

@samarjeet27 Thank you!

As you can see, both builds fail. Please rename ".jscs.json" to ".jscsrc" and run locally before pushing.

samarsault commented 9 years ago

@namangoel1 renamed and runs fine locally !

namangoel1 commented 9 years ago

Thank you! Are there any style errors in JS pointed out by JSCS? I'm waiting for Travis' logs, but it seems that this fails again.

namangoel1 commented 9 years ago

As you can see, travis still fails. Have you checked locally properly?

roonyh commented 9 years ago

@samarjeet27 I have messed up in that tasks description. I am sorry :cry:

we need to edit a .jscsrc file not .jscs.json. i see that @namangoel1 has updated this. Can you please update your fork and resubmit your pull request?

this is really due to my error. I am sorry again.

samarsault commented 9 years ago

Check https://github.com/fossasia/fossasia.github.io/pull/222