search

fossasia / gci14.fossasia.org

FOSSASIA Google Code-In Website 2014/15 http://gci14.fossasia.org
1.57k stars 109 forks source link

Image existence test and fixing issues #225

Closed namangoel1 closed 9 years ago

namangoel1 commented 9 years ago

automatically run by travis to check if there's some file mentioned in the json files that does not exist in images directory.

namangoel1 commented 9 years ago

@RoonyH Can this be merged?

namangoel1 commented 9 years ago

This now fixes #237 and #238

@RoonyH let me know if it's okay to merge.

roonyh commented 9 years ago

Ah. I haven't check this yet. The problem I saw on the first look is this goes through the images list for a second time. I would like to have both tests we have, imagesize and this, to do it in one go. Anyway we will get to it later. Please merge if Travis is green.

Have you worked with git branches? You can work in different git branches which allows you to submit separate pull requests for separate work. Which avoids conflicts like these. On Jan 8, 2015 9:34 PM, "namangoel1" notifications@github.com wrote:

This now fixes #237 https://github.com/fossasia/fossasia.github.io/issues/237 and #238 https://github.com/fossasia/fossasia.github.io/issues/238

@RoonyH https://github.com/RoonyH let me know if it's okay to merge.

— Reply to this email directly or view it on GitHub https://github.com/fossasia/fossasia.github.io/pull/225#issuecomment-69200984 .

namangoel1 commented 9 years ago

@RoonyH Understood, you're correct. I'll merge and then work on combining the two.

Didn't know about that, will do. Thanks!