Closed samarsault closed 9 years ago
Hi! This will be a nice addition to the site!! Thanks much!
But it seems that you are making some unnecessary indentation changes to the index.html file. Can you please remove them and commit only the necessary changes?
I formatted the index.html file
Now the index.html file shows changes in every line. see: https://github.com/fossasia/fossasia.github.io/pull/45/files
Its because you have indented <head>
and <body>
tags. Your change probably is correct but its a little difficult to see what you exactly changed to add the slider.
Alright, I fixed the indentation. Is the new one ok ?
Yep that works. Thanks. Will merge this soon.
I tested this locally. It works fine! Can you tell me where you got the images from?
I got the images from fossasia's flickr page provided on the task website
Please "finish" the task On Dec 10, 2014 7:55 PM, "Samarjeet" notifications@github.com wrote:
I got the images from fossasia's flickr page provided on the task website
— Reply to this email directly or view it on GitHub https://github.com/fossasia/fossasia.github.io/pull/45#issuecomment-66458074 .
Added Image Slider to GCI Site Task : http://www.google-melange.com/gci/task/view/google/gci2014/5551653621071872