search

fossasia / gci14.fossasia.org

FOSSASIA Google Code-In Website 2014/15 http://gci14.fossasia.org
1.57k stars 109 forks source link

Added Image Slider #45

Closed samarsault closed 9 years ago

samarsault commented 9 years ago

Added Image Slider to GCI Site Task : http://www.google-melange.com/gci/task/view/google/gci2014/5551653621071872

roonyh commented 9 years ago

Hi! This will be a nice addition to the site!! Thanks much!

But it seems that you are making some unnecessary indentation changes to the index.html file. Can you please remove them and commit only the necessary changes?

samarsault commented 9 years ago

I formatted the index.html file

roonyh commented 9 years ago

Now the index.html file shows changes in every line. see: https://github.com/fossasia/fossasia.github.io/pull/45/files

Its because you have indented <head> and <body> tags. Your change probably is correct but its a little difficult to see what you exactly changed to add the slider.

samarsault commented 9 years ago

Alright, I fixed the indentation. Is the new one ok ?

roonyh commented 9 years ago

Yep that works. Thanks. Will merge this soon.

roonyh commented 9 years ago

I tested this locally. It works fine! Can you tell me where you got the images from?

samarsault commented 9 years ago

I got the images from fossasia's flickr page provided on the task website

roonyh commented 9 years ago

Please "finish" the task On Dec 10, 2014 7:55 PM, "Samarjeet" notifications@github.com wrote:

I got the images from fossasia's flickr page provided on the task website

— Reply to this email directly or view it on GitHub https://github.com/fossasia/fossasia.github.io/pull/45#issuecomment-66458074 .

roonyh commented 9 years ago

merged