roonyh
commented
9 years ago Hi thanks much for your work and suggestions! Really value them! Welcome to our repo!
So since you were working on two/three days' old code and you replaced the existing index.html file with yours merging this pr would cancel out some work added in the last couple of days. You can check out the changes merging this would bring here: https://github.com/fossasia/fossasia.github.io/pull/82/files So Merging this would be a little problematic. Don't worry, this is a common mistake we face when working in teams.
Please kindly submit a new pull request considering following ideas.
I'll respond to each of your changes.
The logo compacts when the window is resized, i.e., the 'FOSSASIA' logo at the top left corner >shortens to just an icon when viewed in a mobile phone. This was done as the whole logo looked a >bit clumsy in a mobile phone.
When viewed in a mobile phone, the 'fossasia' logo was getting placed above the menu. Changed it >so that in a mobile or a tablet, it is placed right before the menu and in a desktop, it is outside of the >menu's 'div'.
Hmm. Nice change. But I just merged changes from another student which adds a side bar for mobile version and completely remove the top bar. So I would like to go with that change. Its completely our fault for not putting up specific tasks and putting on generic tasks like "Improve mobile version". This has resulted in duplicate work from students. So I am really sorry; let's remove this change for now.
On the first slide, there was an image placed which read 'fossasia'. However, it appeared clumsy on a >mobile phone. Therefore, when viewed in mobile or a tablet, there will be a written text shown and >when viewed on a screen, the image.
I completely support this change! very nice! lets get this in.
The font-size of the navigation menu at the top is reduced when viewed on a mobile device. With the >default size, it was taking more space than required.
So as said above navigation menu is removed now. :cry:
Some text has been added to a few backgrounds (slides) and a button has been added to the slides >which did not have them this earlier. This has been done to make the slides look more uniform.
Excellent!! I was worried about these slides not being uniform and this fixes it satisfyingly. Thanks. keep this change.
Among the languages which thanked all the contributors, there was one which '??????', that has >been removed.
Don't! You were seeing "?????" probably because your browser not supporting those unicode characters. I could see these Burmese characters fine. So please don't remove them.
Change the title 'Map' to 'Find Us Near You' as it was evident from the map itself that it was a map, >'Find Us Near You' seems to me would better the UX.
So these locations mark independent open source related communities. So "Us" is not fitting terminology. That indicates like they are like branches of fossasia. I agree that "Map" is really boring and not appalling at all. But lets just keep it for now.
Other changes are ok. But keeping above mentioned work would be enough for this task. I am really sorry about not being able to merge this pr directly. Its completely our fault.
Its great that you took time to describe your changes so extensively. Made this review much easier. Thanks again for working with us! Please submit another pull request with above asked changes.
akshattripathi
The changes made: The logo compacts when the window is resized, i.e., the 'FOSSASIA' logo at the top left corner shortens to just an icon when viewed in a mobile phone. This was done as the whole logo looked a bit clumsy in a mobile phone.
When viewed in a mobile phone, the 'fossasia' logo was getting placed above the menu. Changed it so that in a mobile or a tablet, it is placed right before the menu and in a desktop, it is outside of the menu's 'div'.
On the first slide, there was an image placed which read 'fossasia'. However, it appeared clumsy on a mobile phone. Therefore, when viewed in mobile or a tablet, there will be a written text shown and when viewed on a screen, the image.
The above three were implemented using JavaScript. They have been written in such a manner so that the functions for all the three get invoked on document load and when resized.
The font-size of the navigation menu at the top is reduced when viewed on a mobile device. With the default size, it was taking more space than required.
Some text has been added to a few backgrounds (slides) and a button has been added to the slides which did not have them this earlier. This has been done to make the slides look more uniform.
Among the languages which thanked all the contributors, there was one which '??????', that has been removed.
Moved the twitter feed at the end as it seemed as though the photo stream should get more priority.
Change the title 'Map' to 'Find Us Near You' as it was evident from the map itself that it was a map, 'Find Us Near You' seems to me would better the UX.
Added 'Photo Stream' above the photo stream to label what the box actually contained (at first glance, to me, seemed as though it was a video :D ).
Added a custom color of selection-- the text which is selected -- to make the site more appealing.
Changed the opacity of the masthead as it made the actual text in the background hard to read.
Also, when hovered over the masthead, its background changes so that there is interference between the header's text and the text in the background.
When hovered over individual menu items, there is an underline done and a 1 second transition to make the selection more apparent and smooth.
Changed the font of all the headings (above the content, this is below the header) to make it more attractive.
Changed the size of the subscribe's input box as it showed only a few characters in the box when viewed on a mobile device which made it difficult to understand what was supposed to be entered.