francoismichel / ssh3

SSH3: faster and rich secure shell using HTTP/3, checkout our article here: https://arxiv.org/abs/2312.08396 and our Internet-Draft: https://datatracker.ietf.org/doc/draft-michel-ssh3/
https://arxiv.org/abs/2312.08396
Apache License 2.0
3.27k stars 82 forks source link

use fqdn for module #74

Closed drewwells closed 9 months ago

drewwells commented 9 months ago

Used gofmt to rename ssh3 to github.com/francoismichel/ssh3. The code hasn't been formatted so this resulted in a lot of whitespace changes.

mpiraux commented 9 months ago

Before I jump into the changes, it would be nice to find a way to enforce gofmt. Ideally it would be in a separated workflow. But also being able to run it before commit would be a good thing.

Maybe making a Makefile ? It could also setup a pre-commit script, but I'm not very knowledgeable on this part. This could end up in a dedicated issue though.

drewwells commented 9 months ago

Before I jump into the changes, it would be nice to find a way to enforce gofmt. Ideally it would be in a separated workflow. But also being able to run it before commit would be a good thing.

Maybe making a Makefile ? It could also setup a pre-commit script, but I'm not very knowledgeable on this part. This could end up in a dedicated issue though.

I agree, the workflow should be turned into a makefile.

as far as enforcing go fmt, the code I add would do this. Most people configure their ide to use go fmt.