frankaemika / libfranka

C++ library for Franka research robots
https://frankaemika.github.io
Apache License 2.0
244 stars 158 forks source link

commandNotPossibleMsg(): improve error message #124

Closed rhaschke closed 2 years ago

rhaschke commented 2 years ago

Replace multiple occurrences of identical error messages with a function. Ideally, the current mode would be shown there as well, i.e. command rejected: command not possible in the current mode (reflex)!

However, I didn't find the corresponding mode member immediately - there are so many similar mode members!

rhaschke commented 2 years ago

I think the mode in the error message refers to RobotMode. I added a corresponding field to allow for reporting that mode.

marcbone commented 2 years ago

Thanks for your PR. This should make the error message much clearer. I added an additional message for the mode "other" that suggests to open the brakes