If I completely rewrite your CMakeLists' to use modern and idiomatic CMake, would you consider merging it?
Is there any reason to you're stuck on CMake 3.4?
The lengthy, descriptive issue:
Hey there!
At my work, we're using libFranka to command our pandas. It turned out to be quite hard to set up the dependencies on Windows for libFranka to compile properly.
To mitigate those issues, I wrote a "new" CMakeLists, with the following changes:
Search for POCO; if POCO is not available, download, configure and build it like any other target.
(Same spiel for Eigen and Google Test)
Reformatted and started using new CMake functions such as target_link_options and etc..
This allows us, to use libFranka, without actually installing it. E.g. in our projects, we use FetchContent (or to be more precise, CPMFindPackage, which is find_package + FetchContent but in useful) to download libFranka and resolve its dependencies with the procedure described above.
This doesn't require the user to have anything set up, besides a proper C++14 Compiler and CMake, and makes the build "bulletproof".
I'd like to open a pull request and incorporate those changes, as well as other changes that clean up the build scripts.
This would allow anyone to get libFranka, your work, running easily, without any hassles.
However, this would require at least CMake 3.13 and a bit more work from my side.
Would you accept such a contribution?
Regards,
Julian
P.S.: The fork I am working on currently, is not done yet, but works for builds using libFranka
This issue became quite lengthy; thus the TL;DR:
The lengthy, descriptive issue:
Hey there! At my work, we're using libFranka to command our pandas. It turned out to be quite hard to set up the dependencies on Windows for libFranka to compile properly.
To mitigate those issues, I wrote a "new" CMakeLists, with the following changes:
target_link_optionsand etc..This allows us, to use libFranka, without actually installing it. E.g. in our projects, we use
FetchContent(or to be more precise,CPMFindPackage, which isfind_package+FetchContentbut in useful) to download libFranka and resolve its dependencies with the procedure described above. This doesn't require the user to have anything set up, besides a proper C++14 Compiler and CMake, and makes the build "bulletproof".I'd like to open a pull request and incorporate those changes, as well as other changes that clean up the build scripts.
This would allow anyone to get libFranka, your work, running easily, without any hassles.
However, this would require at least CMake 3.13 and a bit more work from my side. Would you accept such a contribution?
Regards, Julian
P.S.: The fork I am working on currently, is not done yet, but works for builds using libFranka