add some cpack configurations and rpm builds

[ntorresalberto]

Hi, I've added:

• Building rpm packages (with the same information that was used for .deb packages)
• The USE_SOURCE_PERMISSIONS allows maintaining the original permissions in the case of creation of while using install(DIRECTORY ...) (check docs).
• The use of CMAKE_INSTALL_DEFAULT_DIRECTORY_PERMISSIONS sets default permissions. By default, it has WORLD_WRITE was enabled which makes no sense for installed system files.
• Using the CPACK_DEBIAN_PACKAGE_RELEASE (the proper way to set a build number according to cpack docs). To expand a bit on this, CPACK_DEBIAN_PACKAGE_VERSION has the MAJOR.MINOR.PATCH-RELEASE info deduced from CPACK_PACKAGE_VERSION (which in term comes from the project VERSION string) and should not be manually modified. Here's a quote from the cpack docs:

  This is the numbering of the DEB package itself, i.e. the version of the packaging and not the version of the content (see CPACK_DEBIAN_PACKAGE_VERSION). One may change the default value if the previous packaging was buggy and/or you want to put here a fancy Linux distro specific numbering.

• With this change, future builds that do not change the contents (i.e. library version) but do imply a new release build of the same library version should be set in PACKAGE_RELEASE variable. Example: you've released libfranka-0.8.0-1 and now want to release libfranka-0.8.0-2 (there must be a new commit with set(PACKAGE_RELEASE 2)).

[sgabl]

Thanks for the contribution!

A quick fix to fix the build:

diff --git a/.ci/Dockerfile.bionic b/.ci/Dockerfile.bionic
index fb92e82..07688fb 100644
--- a/.ci/Dockerfile.bionic
+++ b/.ci/Dockerfile.bionic
@@ -11,5 +11,6 @@ RUN apt-get update && apt-get install -y \
     libeigen3-dev \
     libpoco-dev \
     rename \
+    rpm \
     valgrind \
     && rm -rf /var/lib/apt/lists/*
diff --git a/.ci/Dockerfile.focal b/.ci/Dockerfile.focal
index c15aade..55c0b3b 100644
--- a/.ci/Dockerfile.focal
+++ b/.ci/Dockerfile.focal
@@ -12,5 +12,6 @@ RUN apt-get update && apt-get install -y \
     libeigen3-dev \
     libpoco-dev \
     rename \
+    rpm \
     valgrind \
     && rm -rf /var/lib/apt/lists/*
diff --git a/.ci/Dockerfile.xenial b/.ci/Dockerfile.xenial
index 0fbc135..393006e 100644
--- a/.ci/Dockerfile.xenial
+++ b/.ci/Dockerfile.xenial
@@ -11,5 +11,6 @@ RUN apt-get update && apt-get install -y \
     libeigen3-dev \
     libpoco-dev \
     rename \
+    rpm \
     valgrind \
     && rm -rf /var/lib/apt/lists/*

[ntorresalberto]

Thanks for the contribution!

A quick fix to fix the build:

I added these changes and rebased the branch over develop but github is not reflecting the changes. Should I create a new PR? Here's the commit: https://github.com/ntorresalberto/libfranka/commit/31e5e39e6882309a020267fbcb126212268c4dac

edit: nevermind, it's showing now.

[fwalch]

Merged, thank you!

[ntorresalberto]

Hi, @fwalch @sgabl I've recently tried to use this functionality but according to the main CMakeLists.txt commit history these changes are no longer available since commit cac09ea3377f76f51c5d734f4d9a69701cebc468 even though they do appear in the previous commit 700e3808e6a4289ceca0a4a1c87af0e4fca12b5f.

I don't see the removal of the relevant code in the changelog so I guess it could have been a bad merge or a push force somewhere? Would it be possible to cherry-pick these changes?

[marcbone]

Uh yeah something strange happened there. I am sorry. We also have the problem that some changes that happend in the CmakeList were resulting in failing builds on the ROS buildfarm. As it only happens on the buildfarm and not in the test builds for the buildfarm, we can only test by doing a full release. So for the next time we will probably try to revert all the changes in CMakeLists.txt or maybe we find the root cause of the problem. Then we can probably reapply your changes.