search

freckle / yesod-auth-oauth2

OAuth2 authentication for yesod
MIT License
71 stars 53 forks source link

use onErrorHtml for errors #141

Closed pbrisbin closed 3 years ago

pbrisbin commented 3 years ago

Presently, when we encounter exceptions during OAuth2 login, we:

This is fine, but using onErrorHtml is more conceptually correct, and respects user-choice in terms of how to handle auth errors. And using onErrorHtml loginDest message will result in the same behavior in a default YesodAuth instance.

pbrisbin commented 3 years ago

Fixed in ab17f214eb4805f3c21aa1eeb9bc224c699aff05.