search

freckle / yesod-auth-oauth2

OAuth2 authentication for yesod
MIT License
71 stars 53 forks source link

Add twitch.tv plugin #159

Closed chiroptical closed 2 years ago

chiroptical commented 2 years ago

I recently put together a Twitch plugin. Let me know if there is anything I can do to test. My guess is that you will need to create credentials at https://dev.twitch.tv, plug them into the Heroku instance, and then it should work.

chiroptical commented 2 years ago

I didn't see a format or weeder make target, might be useful to provide or give instructions.

pbrisbin commented 2 years ago

It's OK. I would just merge the Restyled PR if it mattered -- or there are instructions in its PR description if you'd like to incorporate its changes locally. I handle auto-formatting locally through editor integrations, hence no make target.

In this case, this (older) project is a little too mis-formatted and I need to make a one-time formatting pass anyway, so I'm inclined to ignore it for now.

If you're happy with this PR, I'll merge on green CI.

chiroptical commented 2 years ago

Nice. I am good with this. I want to open up another PR to explain the callback shape (it took me awhile to figure it out) but I think that will happen upstream.