freedomofpress / securedrop-workstation

Qubes-based SecureDrop Journalist Workstation environment for submission handling
GNU Affero General Public License v3.0
137 stars 42 forks source link

Updater: use Qubes Updater's "stale-detection" functionality and replace VM updatedness checks #1141

Open deeplow opened 2 months ago

deeplow commented 2 months ago

Description

Recently the Qubes updater started conditionally targeting templates based on how long ago they had their updates checked and reported as having updates. So we should consider dropping the --force-update flag introduced by https://github.com/freedomofpress/securedrop-workstation/issues/1140 and move to an --update-if-stale 1.

This requires:

The end result will be that sometimes the updater will have no template to update. So it's kind of a shortcut to always having to update all the templates.

How will this impact SecureDrop/SecureDrop Workstation users?

Not much, since all templates are updated at the same time, anyways.

How would this affect the SecureDrop Workstation threat model?

It shouldn't.

User Stories

As an SDW developer, I'd like to have less code and delegate functionality to Qubes features that have superseded our own implementation.

deeplow commented 2 months ago

Copy-pasting some support for this from another thread as not to loose track of it.

@rocodes says:

[...] Briefly I'd be in favour of moving to every 24h and update-if-stale 1 and the GUI updater after this release [1.0.0] [...]