search

freedomofpress / securedrop-workstation

Qubes-based SecureDrop Journalist Workstation environment for submission handling
GNU Affero General Public License v3.0
137 stars 41 forks source link

Newly installed Fedora template is not getting updates right after install #1166

Open deeplow opened 2 weeks ago

deeplow commented 2 weeks ago

Description

Due to the wrong variable fedora-40 was being updated instead of the newly fetched fedora-40-xfce. fedora-40 does not exist in default systems and the salt updater was silently failing.

This should not affect current installations, since in 4.2.2 already came with fedora-40-xfce and thus no actual template upgrades have occurred.

Steps to Reproduce

No need to reproduce. Visual inspection suffices.

Expected Behavior

Downloaded template is updated immediately

Actual Behavior

Silent failure.

rocodes commented 2 weeks ago

Thanks for the fix. Just to share a bit more of our discussion re impact here on GitHub: Users are instructed to apply system updates before provisioning SDW in order to ensure that system VMs are fully up to date. So this is an extra assurance measure relevant to provisioning (and should be a no-op under normal circumstance), but should of course be fixed. Thus our decision to treat this as part of the normal release cadence.

After provisioning, the built-in updater handles template updates and correctly updates fedora-40-xfce.