freeipa / freeipa-healthcheck

Check the health of a freeIPA installation
GNU General Public License v3.0
50 stars 28 forks source link

prometheus output plugin violates format spec #292

Closed UiP9AV6Y closed 1 year ago

UiP9AV6Y commented 1 year ago

the prometheus output plugin renders HELP and TYPE annotations without the required '#' prefix, which is required according to the format specification

the problem can be reproduced by running the following command: ipa-healthcheck --all --output-type prometheus

expected output

# HELP ipa_healthcheck Number of healthchecks with a certain result
# TYPE ipa_healthcheck gauge
ipa_healthcheck{result="SUCCESS"} 1.0

actual output

HELP ipa_healthcheck Number of healthchecks with a certain result
TYPE ipa_healthcheck gauge
ipa_healthcheck{result="SUCCESS"} 1.0