search

frequenz-floss / frequenz-api-electricity-trading

gRPC+protobuf specification and Python bindings for the Frequenz Electricity Trading API
MIT License
0 stars 6 forks source link

Use HasField method on protobuf messages #53

Closed matthias-wende-frequenz closed 6 months ago

matthias-wende-frequenz commented 7 months ago

Just testing if a message is None is not enough and leads to unexpected results.

nhatcher-frequenz commented 7 months ago

One more thing, is it possible to add a test that would fail without this change but pass with the change? Or that is not possible in this case?

tiyash-basu-frequenz commented 7 months ago

The label looks incorrect .. repo-config issue maybe?

matthias-wende-frequenz commented 6 months ago

One more thing, is it possible to add a test that would fail without this change but pass with the change? Or that is not possible in this case?

Yes that should be addressed asap.