search

frescobaldi / python-poppler-qt5

Python binding to libpoppler-qt5
Other
42 stars 32 forks source link

Remove build system for sip v4 #59

Closed jeanas closed 1 year ago

jeanas commented 1 year ago

The last bugfix release of sip 4 was in February 2018, 5 years ago. Even sip 5 is now unsupported. It should be safe to remove the parallel build system for sip 4 in favor of the sip 5/6 build system defined in pyproject.toml and project.py, avoiding the need to maintain two build systems in parallel.

fedelibre commented 1 year ago

Can you also bump the minimum sip version required in the INSTALL file? (while on it I would also remove the (tested with 2.6) referred to Python)

jeanas commented 1 year ago

Thanks for reminding me.

jeanas commented 1 year ago

Let’s merge it?

fedelibre commented 1 year ago

Ok, go ahead