frintjs / frint

Modular JavaScript framework for building scalable and reactive applications
https://frint.js.org/
MIT License
756 stars 37 forks source link

frint: Expose class methods on the app instance level #431

Closed rbardini closed 6 years ago

rbardini commented 6 years ago

What's done

Why

Allow access to public methods directly from the app instance, besides the options property.

Closes #426.

codecov[bot] commented 6 years ago

Codecov Report

Merging #431 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   97.75%   97.76%   +<.01%     
==========================================
  Files         112      112              
  Lines        4366     4380      +14     
==========================================
+ Hits         4268     4282      +14     
  Misses         98       98
Impacted Files Coverage Δ
packages/frint/src/App.spec.ts 100% <100%> (ø) :arrow_up:
packages/frint/src/App.ts 99.37% <100%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update abb7964...21c4214. Read the comment docs.

fahad19 commented 6 years ago

Great stuff, @rbardini! 💖