search

frozn / TipTac

WoW AddOn TipTac Reborn
GNU General Public License v3.0
107 stars 20 forks source link

Error when mousing over other players #279

Closed Bronsin closed 1 month ago

Bronsin commented 3 months ago

I get the below error when I mouse over other players. Happens on all characters, multiple classes. Just started happening today.   173x TipTac/ttStyle.lua:562: attempt to index a nil value [string "@TipTac/ttStyle.lua"]:562: in function ModifyUnitTooltip' [string "@TipTac/ttStyle.lua"]:764: in function?' [string "@TipTac/libs/LibFroznFunctions-1.0-19/LibFroznFunctions-1.0.lua"]:1038: in function FireGroupEvent' [string "@TipTac/ttCore.lua"]:2814: in functionSetUnitAppearanceToTip' [string "@TipTac/ttCore.lua"]:2917: in function ?' [string "@TipTac/libs/LibFroznFunctions-1.0-19/LibFroznFunctions-1.0.lua"]:1038: in functionFireGroupEvent' [string "@TipTac/ttCore.lua"]:1640: in function `SetCurrentDisplayParams' [string "@TipTac/ttCore.lua"]:1515: in function <TipTac/ttCore.lua:1514> [string "@TipTac/libs/LibFroznFunctions-1.0-19/LibFroznFunctions-1.0.lua"]:344: in function <...libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua:342>

string "=[C]": in function securecallfunction' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:162: in function <SharedXML/Tooltip/TooltipDataHandler.lua:157> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:182: in function <SharedXML/Tooltip/TooltipDataHandler.lua:178> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:218: in function <SharedXML/Tooltip/TooltipDataHandler.lua:208> [string "=[C]"]: in functionSetAttribute' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:243: in function <SharedXML/Tooltip/TooltipDataHandler.lua:236> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:389: in function <SharedXML/Tooltip/TooltipDataHandler.lua:339> string "=[C]": in function securecallfunction' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:336: in functionProcessInfo' [string "@FrameXML/GameTooltip.lua"]:1094: in function `SetWorldCursor' [string "@FrameXML/UIParent.lua"]:1527: in function <FrameXML/UIParent.lua:1450>

Locals: self =

{ GenerateTargetLines = defined @TipTac/ttStyle.lua:203 OnTipResetCurrentDisplayParams = defined @TipTac/ttStyle.lua:767 OnConfigLoaded = defined @TipTac/ttStyle.lua:731 GenerateNpcLines = defined @TipTac/ttStyle.lua:452 GeneratePetLines = defined @TipTac/ttStyle.lua:420 OnTipSetCurrentDisplayParams = defined @TipTac/ttStyle.lua:737 GeneratePlayerLines = defined @TipTac/ttStyle.lua:341 ModifyUnitTooltip = defined @TipTac/ttStyle.lua:474 GenerateTargetedByLines = defined @TipTac/ttStyle.lua:229 OnTipStyle = defined @TipTac/ttStyle.lua:745 HighlightTipTacDeveloper = defined @TipTac/ttStyle.lua:261 RemoveUnwantedLinesFromTip = defined @TipTac/ttStyle.lua:151 } tip = GameTooltip { SetATTReferenceForTexture = defined @AllTheThings/src/UI/Game Tooltip.lua:272 ItemTooltip = Frame { } SetHyperlink = defined =[C]:-1 SetAzeriteEssence = defined =[C]:-1 SetVoidDepositItem = defined =[C]:-1 ClearATTReferenceTexture = defined @AllTheThings/src/UI/Game Tooltip.lua:265 AllTheThingsOnTooltipClearedHook = true SetTraitEntry = defined @SharedXML/Tooltip/TooltipDataHandler.lua:539 ClearBackdrop = defined =[C]:-1 SetLootCurrency = defined @SharedXML/Tooltip/TooltipDataHandler.lua:539 SetWorldCursor = defined @FrameXML/GameTooltip.lua:1076 SetLootItem = defined =[C]:-1 GetSpell = defined @FrameXML/GameTooltip.lua:1114 SetQuestLogSpecialItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:539 SetRecipeReagentItem = defined @Altoholic/Services/Tooltip.lua:621 SetMerchantItem = defined =[C]:-1 BottomOverlay = Texture { } SetSocketedRelic = defined @SharedXML/Tooltip/TooltipDataHandler.lua:539 ProcessInfo = defined @SharedXML/Tooltip/TooltipDataHandler.lua:335 NineSlice = Frame { } SetInventoryItem = defined =[C]:-1 TopEdge = Texture { } SetUnitDebuffByAuraInstanceID = defined =[C]:-1 GetProcessingTooltipInfo = defined @SharedXML/Tooltip/TooltipDataHandler.lua:488 SetBackdropColor = defined =[C]:-1 LeftEdge = Texture { } AddLineDataText = defined @SharedXML/Tooltip/TooltipDataHandler.lua:429 AppendInfo = defined @SharedXML/Tooltip/TooltipDataHandler.lua:525 SetSpellBookItem = defined =[C]:-1 textLeft1Font = "GameTooltipHeaderText" AppendInfoWithSpacer = defined @SharedXML/Tooltip/TooltipDataHandler.lua:531 SetShapeshift = defined @SharedXML/Tooltip/TooltipDataHandler.lua:539 SetArtifactPowerByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:539 textRight2Font = "GameTooltipText" TopOverlay = Texture { } SetSocketedItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:539 SetUnitDebuff = defined =[C]:-1 SetWorldLootObject = defined @SharedXML/Tooltip/TooltipDataHandler.lua:539 SetMountBySpellID = defined =[C]:-1 SetBorderBlendMode = defined @SharedXML/Backdrop.lua:266 SetTrainerService = defined =[C]:-1 TextLeft1 = GameTooltipTextLeft1 { } GetTooltipData = defined @SharedXML/Tooltip/TooltipDataHandler.lua:505 IsTooltipType = defined @SharedXML/Tooltip/TooltipDataHandler.lua:509 OnBackdropSizeChanged = defined @SharedXML/Backdrop.lua:182 ClearHandlerInfo = defined @SharedXML/Tooltip/TooltipD

srhinos commented 3 months ago

Ran into the same issue. Looks like GetDungeonScoreRarityColor isnt working? Super weird

Anyway, in the interim I just disabled these lines in ttStyle.lua

itsSinba commented 3 months ago

It's indeed _CChallengeMode.GetDungeonScoreRarityColor that now returns nil since today's update. I'm also trying to figure it out, in the meantime you only need to uncheck the option "Show Mythic+ Dungeon Score" option in General, no need to comment out the code

acx-nvstar commented 3 months ago

uncheck this and everything will be back to normal image

frozn commented 3 months ago

Thanks for reporting this! 👍

It's now considered that C_ChallengeMode.GetDungeonScoreRarityColor() to determine the mythic+ dungeon score color may return nil: https://github.com/frozn/TipTac/blob/af15500f780bd8bc523e76e3f8a7f2c3e50751b6/TipTac/modules/ttStyle.lua#L557-L564

Will be included in the next release.

Ookami313 commented 2 months ago

Not sure if it makes a difference, I was getting the same error, but when I moused over items in my bag as well. I updated my ttStyle.lua file using a copy of the one above ("Save link as" and overwrote the one in the main directory) with what I assumed contained the fixes in it. I'm now getting the following errors when I log into the game. The addon seems to work fine, just keep getting errors if I log out to switch characters and such. Thanks.

1x TipTac/ttStyle.lua:7: unexpected symbol near '<'

Locals:

2x TipTac/ttStyle.lua:1 TipTac/ttStyle.lua:7: unexpected symbol near '<'

frozn commented 2 months ago

"Save link as" doesn't work for downloading individual files. You have to navigate to "ttStyle.lua" and click on it (https://github.com/frozn/TipTac/blob/main/TipTac/modules/ttStyle.lua). On the screen now displaying the contents of "ttStyle.lua" you have to click on button "Download raw file":

image

Ookami313 commented 2 months ago

Awesome, thank you very much.

"Save link as" doesn't work for downloading individual files. You have to navigate to "ttStyle.lua" and click on it (https://github.com/frozn/TipTac/blob/main/TipTac/modules/ttStyle.lua). On the screen now displaying the contents of "ttStyle.lua" you have to click on button "Download raw file":

image

Awesome, thank you very much.

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.