Closed clintval closed 5 years ago
Merging #347 into master will increase coverage by
0.09%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 91.44% 91.53% +0.09%
==========================================
Files 31 31
Lines 1145 1146 +1
Branches 115 108 -7
==========================================
+ Hits 1047 1049 +2
+ Misses 98 97 -1
Impacted Files | Coverage Δ | |
---|---|---|
...src/main/scala/dagr/core/execsystem/Resource.scala | 95.91% <100%> (+2.16%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 324f219...d4f8654. Read the comment docs.
@clintval in your example, I think val cores: Cores = 6.0
will still need to be val cores: Cores = Cores(6.0)
as there's no implicit in scope to convert type Double
to type Cores
, but other than that, LGTM.
I have a pipeline where I would like to parameterize the compute resources for one of the tasks using the CLI like this toy example:
At runtime I get:
Would you be willing to allow for building
Core
resources from Strings?EDIT: Fixed type of cores in toy example.