search

fulcrumgenomics / dagr

A scala based DSL and framework for writing and executing bioinformatics pipelines as Directed Acyclic GRaphs
MIT License
69 stars 14 forks source link

Add support for empty tasks #360

Closed nh13 closed 5 years ago

nh13 commented 5 years ago
  1. Tasks.getTasks can now return an empty list of tasks to run (ex. None, Seq.empty) and the execution system will set the parent task to completed.
  2. Added a Tasks$.empty method to create a small task whose getTasks method returns None.
tfenne commented 5 years ago

One other thought would be whether it would make sense to add something like def EmptyTask: Task = Task.empty to Pipeline?

codecov-io commented 5 years ago

Codecov Report

Merging #360 into master will increase coverage by 0.19%. The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
+ Coverage   91.84%   92.03%   +0.19%     
==========================================
  Files          31       31              
  Lines        1140     1155      +15     
  Branches       71       66       -5     
==========================================
+ Hits         1047     1063      +16     
+ Misses         93       92       -1
Impacted Files Coverage Δ
...src/main/scala/dagr/core/tasksystem/Pipeline.scala 85% <0%> (-4.48%) :arrow_down:
...ore/src/main/scala/dagr/core/tasksystem/Task.scala 96.96% <100%> (+0.14%) :arrow_up:
.../main/scala/dagr/core/execsystem/TaskManager.scala 92.85% <96.55%> (+1.3%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c5364a...86e749b. Read the comment docs.