fulcrumgenomics / dagr

A scala based DSL and framework for writing and executing bioinformatics pipelines as Directed Acyclic GRaphs
MIT License
69 stars 14 forks source link

Add CorrectUmis to dagr tasks #366

Closed gpratt closed 5 years ago

gpratt commented 5 years ago

CorrectUmis from fgbio doesn't have a corresponding dagr task. This PR adds that task.

Preliminary tests indicate this task works for my purposes, so I'm happy.

Two open questions for this PR:

  1. The style of the tasks in dagr is a bit inconsistent, I used the FilterConsensusReads style just because it was a nice guide for all the features I wanted to use. Let me know if you want to use a different style here.
  2. There is currently no scaladoc in dagr tasks. Let me know if you want to start adding scaladoc.
codecov-io commented 5 years ago

Codecov Report

Merging #366 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files          31       31           
  Lines        1156     1156           
  Branches       65       65           
=======================================
  Hits         1063     1063           
  Misses         93       93

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b0bab7...6bc3730. Read the comment docs.

gpratt commented 5 years ago

Done!