Closed tfenne closed 2 years ago
@nh13 You don't actually have to review this, it's basically a patch to make dagr work with common ~1.4. I'm going to merge tomorrow and then cut a release unless I hear from you that you strongly object.
Merging #402 (c9397e1) into master (a27e576) will increase coverage by
0.51%
. The diff coverage is70.58%
.
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 91.40% 91.92% +0.51%
==========================================
Files 31 31
Lines 1187 1164 -23
Branches 77 80 +3
==========================================
- Hits 1085 1070 -15
+ Misses 102 94 -8
Flag | Coverage Δ | |
---|---|---|
unittests | 91.92% <70.58%> (+0.51%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...in/scala/dagr/core/cmdline/DagrScriptManager.scala | 84.84% <68.75%> (+8.48%) |
:arrow_up: |
...rc/main/scala/dagr/core/cmdline/DagrCoreMain.scala | 82.41% <100.00%> (-0.20%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a27e576...c9397e1. Read the comment docs.