Add Card Reader API support for Full Contact

fullcontact / fullcontact-api-ruby

A Ruby wrapper for the FullContact API

MIT License

82 stars 84 forks source link

Add Card Reader API support for Full Contact #22

Open gweakliem opened 10 years ago

gweakliem commented 10 years ago

This commit adds basic support for the Card Reader API http://www.fullcontact.com/developer/docs/card-reader/, specifically the View Requests method.

I have tested only the page parameter but the other parameters (returnedData, format, and diagnostics) should also be supported, although for the format parameter, it doesn't make sense to return XML as the existing gem expects JSON.

The Readme.md has been updated with sample usage.

Xorlev commented 10 years ago

Thanks for your contribution! I've added a few comments above. I'll test this out tomorrow and get back to you with any additional feedback.

gweakliem commented 10 years ago

thanks for the feedback, I've updated my master.

Xorlev commented 10 years ago

Reviewing this for inclusion in 0.8.0, will act by end of week.

nfriend21 commented 9 years ago

Can this get merged? Looking to also have CardReader functionality.

dominicsayers commented 8 years ago

:+1: for merging this

ACPK commented 8 years ago

@Xorlev - Is there a reason this never got merged?

donmb1 commented 7 years ago

+1 for merging this