search

fullcube / loopback-component-migrate

Migration framework for loopback
43 stars 30 forks source link

MigrationMap unused? #8

Open jouke opened 8 years ago

jouke commented 8 years ago

While working on the pull request I just submitted, I noticed that the MigrationMap model seems unused. Apart from the index.js defining the model and the files that define the model, there is absolutely no reference to it.

Can it be removed? I'd rather not have unused tables in my database... :)

Cheers,

Jouke

alireza-ahmadi commented 7 years ago

I also agree with @jouke, MigrationMap seems unused and even it's unit tests are useless. Please let us know if you have not implemented it for a specific reason and it can be removed so we can submit a pull request for that.

Thanks for this useful component and I really appreciate any help you can provide.

mrfelton commented 7 years ago

Hi, The original purpose of the MigrationMap collection was to enable you to store mappings between Object Ids pre and post migration which can be useful if you are migrating data from one system to another where Object Ids are being changed along the way. Arguably this is only useful for certain types of migrations and there are no useful tests for it.

I would consider a pull request that either adds a setting to make the creation of this model optional, or remove it completely from the component.