search

fuzetsu / manga-loader

standardize manga reading experience across the web
129 stars 61 forks source link

Not working on Firefox 57+ and Greasemonkey #2

Open lenisko opened 6 years ago

lenisko commented 6 years ago

bato.to is not working on Firefox 57.0.2

It's working on chrome though... so something is WRONG with newest versions of fx.

lenisko commented 6 years ago

@fuzetsu any idea what might be wrong? like some deprecated methods inside bato.to part? right now it's only loading 'wall' with one picture which was already on page where I have pressed Load Manga and not going any further. Chapter switching is working. Looks like bug is somewhere in loading next page part, but I wasn't able to fix nor even trace it...

KarolS commented 6 years ago

@lenisko It might be related to #7

Also Firefox, also next page loading problem. My fix doesn't fix bato.to though, only Mangafox, so it would have to be fixed more thoroughly.

fuzetsu commented 6 years ago

Hmm, I'm on linux and the latest version of firefox I can run at the moment without some weird sideloading is 52... I'll test it out there, but if @lenisko or someone want's to see if it fixes the issue with firefox in general, it would be appreciated.

lenisko commented 6 years ago

@fuzetsu not really sure how should I "port" this part. But I'll try few more things later.

fuzetsu commented 6 years ago

Maybe I'm misunderstanding what you mean, but I was just saying to run @KarolS version of the script. You can see the full file from his commit here: https://github.com/KarolS/manga-loader/blob/72f499af9e9590c2ec970e05f490a7b2e008d64a/manga-loader.user.js

lenisko commented 6 years ago

@fuzetsu Sorry for confusion. I checked this version, it's not working, nothing useful in console as well 2017-12-14_02-17-54-firefox

fuzetsu commented 6 years ago

Great, thanks for checking. Are you using grease monkey? I'm having issues with it even with firefox 52. Running the script as a bookmarklet or through tampermonkey works fine (even for bato.to).

I'm having trouble debugging the script while on Grease Monkey through the console... So looks like I'll have to set some time aside and start adding some console.logs to figure this one out... In the meantime the workaround is to use Tampermonkey or the bookmarklet.

lenisko commented 6 years ago

@fuzetsu hah... so it was Greasemonkey after all. As bookmarklet it's working just fine. I would like to avoid Tampermonkey it's fishy... lets leave this open

lenisko commented 6 years ago

@fuzetsu looks like xhr.open('get', url); is stuck?...

} else {
  var colonIdx = url.indexOf(':');
  if(colonIdx > -1) {
    url = location.protocol + url.slice(colonIdx + 1);
  }
  log('before xhr');
  xhr.open('get', url);
  imp.beforexhr && imp.beforexhr(xhr);
  xhr.onload = getPageInfo;
  xhr.onerror = function() {
    log('failed to load page, aborting', 'error');
  };
  xhr.send();
  log('after xhr');
}
Manga Loader log: Condition fulfilled, loading
Manga Loader log: before xhr

No GET was sen't as well.

Mar2ck commented 6 years ago

I had this issue too with Greasemonkey on Firefox 57 for Linux. Switched to Violentmonkey and it's working perfectly now.

lenisko commented 6 years ago

@Mar2ck thanks for recommending it, at least it's proper open source project. I'll leave it open.

DavPalma commented 6 years ago

For me it's only loading 2 pages. I suspect it was because of greasemonkey 4. Either a bug in it or the script needs to be updated to be gm4 compatible. As js is not exacly my area of expertise, I'll just leave this here: https://www.greasespot.net/2017/09/greasemonkey-4-for-script-authors.html