g0v / vaccinate

vaxx.tw is a tool to find COVID-19 Vaccine Appointments near you
http://vaxx.tw
MIT License
33 stars 20 forks source link

Add pre-commit command to run eslint fix and type check of flow #60

Closed wt-lin closed 3 years ago

wt-lin commented 3 years ago

Description

Screenshots

wt-lin commented 3 years ago

Can I ask how the lint here work? I have no idea why it reports error.

kevinjcliao commented 3 years ago

master is broken. please rebase! :_

kevinjcliao commented 3 years ago

Haven't had a good time with Husky in the past, but we'll give this another go!

kevinjcliao commented 3 years ago

Hi @i-liszt , how do I set up Husky?

I cloned the repository today, but I'm getting the error that

 Can't open .husky/_/husky.sh

How do get this shell script? I notice that it's gitignored.

wt-lin commented 3 years ago

Can I know how do you set that? I mean, the whole clone and install process.

kevinjcliao commented 3 years ago

I just git pulled the latest repository and ran yarn. Were there extra steps to get Husky to work?

wt-lin commented 3 years ago

OK, I guess I need to add a prepare script. Let me create another PR for this.