g0v / vaccinate

vaxx.tw is a tool to find COVID-19 Vaccine Appointments near you

http://vaxx.tw

MIT License

33 stars 20 forks source link

[1] Add new TypedDict for building AirTable requests #95

Closed kevinjcliao closed 3 years ago

kevinjcliao commented 3 years ago

Context

@SeanGau and I added support for making requests from AirTable URLs recently by making a request through aiohttp.
We are currently passing URL parameters as part of the string. This is not clean code and is messy.

This PR:

Adds an AirTableRequestParams TypedDict that we pass into each asyncio request.

Test Plan:

yarn lint and yarn tc pass successfully.

Screenshots

Popup news continues to load properly

Vaccine locations continue to load properly