g2nb / igv-jupyter

Extension for Jupyter which integrates igv.js
MIT License
154 stars 14 forks source link

Bam reads are cutoff #8

Closed jfear closed 5 years ago

jfear commented 7 years ago

Hey guys, sorry to bug you again.

When loading a BAM file the reads appear to get cutoff. This happens with default setting, and I have played with the display_mode, height, maxRows, and samplingDepth parameters which do not fix the problem.

screen shot 2016-10-27 at 1 02 29 pm

thanks Justin

jrobinso commented 7 years ago

Thanks for the report, we'll look into it.

jrobinso commented 7 years ago

BTW, keep bugging us.

On Thu, Oct 27, 2016 at 10:05 AM, Justin Fear notifications@github.com wrote:

Hey guys, sorry to bug you again.

When loading a BAM file the reads appear to get cutoff. This happens with default setting, and I have played with the display_mode, height, maxRows, and samplingDepth parameters which do not fix the problem.

[image: screen shot 2016-10-27 at 1 02 29 pm] https://cloud.githubusercontent.com/assets/1240432/19777371/e9b87136-9c45-11e6-9267-554e64ce9bd3.png

thanks Justin

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/igvteam/igv.js-jupyter/issues/8, or mute the thread https://github.com/notifications/unsubscribe-auth/AA49HEP8h-b77x-3k-tvE1VN0lbzFjVqks5q4Nn3gaJpZM4KimNH .

jfear commented 7 years ago

I think I have narrowed the problem down. If I change the height attribute on the canvas it seems to look as expected.

Before the change:

screen shot 2016-10-27 at 2 39 37 pm

After the change:

screen shot 2016-10-27 at 2 37 00 pm

Don't know if there is an attribute I should change when making the IGV object or the BAM track, or if this is a bug.

turner commented 7 years ago

Justin that's helpful. I'm looking at this now.

jrobinso commented 7 years ago

Thanks for the info, I think its a bug on our side, you shouldn't have to do that. You should see a scrollbar when the alignments are "cut off", and also you should be able to control the height of the track in the properties.

On Thu, Oct 27, 2016 at 11:47 AM, Justin Fear notifications@github.com wrote:

I think I have narrowed the problem down. If I change the height attribute on the canvas it seems to look as expected.

Before the change:

[image: screen shot 2016-10-27 at 2 39 37 pm] https://cloud.githubusercontent.com/assets/1240432/19780541/74c7d7e6-9c53-11e6-820a-be3752b6480a.png

After the change:

[image: screen shot 2016-10-27 at 2 37 00 pm] https://cloud.githubusercontent.com/assets/1240432/19780549/7b62a8ba-9c53-11e6-931f-0f8bdcef636a.png

Don't know if there is an attribute I should change when making the IGV object or the BAM track, or if this is a bug.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/igvteam/igv.js-jupyter/issues/8#issuecomment-256734400, or mute the thread https://github.com/notifications/unsubscribe-auth/AA49HBt4GlOy_HAGPNFxQJM-ArrloQM3ks5q4PHZgaJpZM4KimNH .

turner commented 7 years ago

I can not reproduce this issues. Are you seeing this with the examples as well. Try "BAM Example.ipynb"

jfear commented 7 years ago

Sorry, just saw that you had replied.

I still get the same thing using the example notebook. I will play with it on some different computers and see if I can figure out if there is something specific to my setup. Nothing in the javascript console jumps out, so it maybe a chrome/osx thing. I will keep you posted.

jrobinso commented 7 years ago

To be clear the "cut off" alignments are normal, what's not normal is the absence of a scrollbar in the track. Also, setting track height should work (it does for us).

On Wed, Nov 2, 2016 at 10:56 AM, Justin Fear notifications@github.com wrote:

Sorry, just saw that you had replied.

I still get the same thing using the example notebook. I will play with it on some different computers and see if I can figure out if there is something specific to my setup. Nothing in the javascript console jumps out, so it maybe a chrome/osx thing. I will keep you posted.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/igvteam/igv.js-jupyter/issues/8#issuecomment-257946695, or mute the thread https://github.com/notifications/unsubscribe-auth/AA49HH4rmOstMZ2BE6dwcP4EzOmbLLlHks5q6M7JgaJpZM4KimNH .

jfear commented 7 years ago

Just to clarify. There is a scroll bar, but the bams are cutoff half way through the read. I can scroll down, but it is just white.

screen shot 2016-11-02 at 1 49 00 pm

I tried messing with the height and maxHeight parameters but they appear to do nothing.

When I get a chance I will test on different browsers/machines and see if there is something strange with my set up.

a-slide commented 5 years ago

I believe this is solved in the last version of the package